search

OmkarPathak / pygorithm

A Python module for learning all major algorithms
MIT License
4.41k stars 510 forks source link

Branches, Deprication #60

Closed IanDoarn closed 7 years ago

IanDoarn commented 7 years ago

To everyone who has contributed.

We've been making quite a few changes recently and generally all the time now. Most of what I've been doing is fixing syntaxing to comply with PEP and in turn have been renaming quite a few things. I've noticed we've been renaming things or restructuring things.

Here's my question(s) to you all:

Who all actively use this?

We change things a lot and this main repository does not have dev branches. Also, and I'm guilty of this, renaming things breaks code. Maybe we should have a dev branch now and also implement a way of warning the user of deprecation. In an old project of mine I implemented decorators for functions that where or were being deprecated.

Just my two cents!

OmkarPathak commented 7 years ago

I agree that we should have a development branch.

IanDoarn commented 7 years ago

@OmkarPathak would you be opposed to granting other people write permissions to this repo? Maybe the highest contributing people?

OmkarPathak commented 7 years ago

I would be happy to give write permissions. I am creating a dev branch and giving necessary permissions in sometime.

IanDoarn commented 7 years ago

@OmkarPathak :+1: Who will you be granting to? I think @Tjstretchalot is an excellent candidate

Tjstretchalot commented 7 years ago

I'm personally happy either way with committing to branches on the main repo and then pull requests into master or committing into my fork then pull requests into master. One advantage of on the main repo is we can see the live documentation without having separate links. One advantage to forks is you can rewrite history if you mess up and it won't be visible to anyone else (unless you have multiple people working on your fork of course)

OmkarPathak commented 7 years ago

I am giving write permissions to @Tjstretchalot as well as @IanDoarn :+1:

OmkarPathak commented 7 years ago

I have also created a dev branch. We three will be making changes on this branch and pushing the commits to the main branch whenever we feel right and all the codes runs without any errors.

Tjstretchalot commented 7 years ago

@OmkarPathak I pushed what I was about to push to my fork to dev to test. We should add a link to the documentation for the dev/ branch in the readme. This issue should help explain it: https://github.com/rtfd/readthedocs.org/issues/4

OmkarPathak commented 7 years ago

Just a little problem. I can't see dev branch in Readthedocs > Admin > Versions

OmkarPathak commented 7 years ago

Solved.