When trying to build a list of all DEX matching transactions for an Omni Core wallet, the omni_gettradehistoryforaddress method is very useful. However, in order to get a timestamp for each matching transaction an additional call for each match must be made to get the transaction (block) time.
Adding a blocktime property to each object in the matches array would eliminate the need for these extra calls. (The blocktime property in the root object is the blocktime for the sell offer, but we also need the time for each matching transaction.)
It might also make sense to add a blocktime property to each match in the response to omni_gettradehistoryforpair.
msgilligan
commented
1 year ago
When trying to build a list of all DEX matching transactions for an Omni Core wallet, the
omni_gettradehistoryforaddressmethod is very useful. However, in order to get a timestamp for each matching transaction an additional call for each match must be made to get the transaction (block) time.Adding a
blocktimeproperty to each object in thematchesarray would eliminate the need for these extra calls. (Theblocktimeproperty in the root object is theblocktimefor the sell offer, but we also need the time for each matching transaction.)It might also make sense to add a
blocktimeproperty to each match in the response toomni_gettradehistoryforpair.