OmniLayer / omniwallet

Omni Protocol Hybrid Web-Wallet
https://www.omniwallet.org
GNU Affero General Public License v3.0
327 stars 187 forks source link

Escrow fund display/redemption #382

Open curtislacy opened 10 years ago

curtislacy commented 10 years ago

As I test, I'm ending up in a weird state where my bitcoin funds are all tied up in escrows, because of big long issuance transactions like this one: https://blockchain.info/tx/ecc90d0fe7185d7b8cee0d87a026a67d568b5a75183a681e7c67211e6cb7ee53

@faizkhan00 has written a script to redeem these: https://github.com/faizkhan00/msc-exchange-scripts/blob/master/redeemMultiSig.py

Thing is, most users won't want to bother with that script, and won't realize what the problem is when things just start failing. The BTC section of Omniwallet should display the amount locked up in escrows for each address, and have a button to redeem them.

ghost commented 10 years ago

https://blockchain.info/tx/0d91e8f5a543a2a4522f4cf416c10aae9e4008bce76058d62207219deed0d2a7

as an example output of redeemMultiSig.py

dexX7 commented 10 years ago

Maybe this is still useful for you: http://redeem.bitwatch.co + http://api.bitwatch.co/listunspent (uses https://github.com/dexX7/bitcoin/tree/addrindex as backend)

ghost commented 10 years ago

Discussed with Yuval:

This will be a default-hidden button, located on the pending offers page, it has a status element with the user funds that can be redeemed, and its clickable, sends your funds in the same way that the send page works.

Do not let user click on the button unless it is above 0.0001 fee.

oktype commented 10 years ago

We might got it wrong.. If the locked up funds are not necessarily related to trades, then we don't want it on the pending orders page. Curtis's solution will suit better (aka the my addresses and address page) so you get indication of the amount of funds locked in each address (or just that there are some of those if too hard to implement at the moment), and will be able to release those (will prompt to redeem confirmation lightbox with the relevant details - amount of redeemable transactions and accumulated sum) maybe with a short explanation about the longer you wait the more you save from those micro transactions

oktype commented 10 years ago

This is actually kinda nice if we think of it as the same way of redeemable refund (we got those on drinking bottles here, you don't go to the store for each bottle, but when you do accumulate some bottles it feels very rewarding (if was beer :) . Its just need to be shown and treated as 'redeemable Bitcoins' asset if Exist, leading to that collective lightbox

@curtislacy why things should start failing? (we need to exclude the funds which are not available)

ghost commented 10 years ago

Multisig front-end signing is still TODO on this, perhaps BitPay Insight could be leveraged here?

achamely commented 10 years ago

Moving forward to v.017. @faizkhan00 any updates or eta on when we should be able to finish this.

ghost commented 10 years ago

A long ways away, its dependant on the DB

dexX7 commented 10 years ago

Well, just keep one thing in mind: you can't combine sweeping and transaction generation in one step due to the input selection that allows only spend-from-pay-to-pubkey-hash and spend-from-pay-to-script-hash.