OmniLayer / omniwallet

Omni Protocol Hybrid Web-Wallet
https://www.omniwallet.org
GNU Affero General Public License v3.0
327 stars 187 forks source link

History page includes MaidSafe Crowdsale creation in tx list for one of my addresses #722

Open marv-engine opened 10 years ago

marv-engine commented 10 years ago

The MaidSafeCoin crowdsale creation tx (86f214055a7f4f5057922fd1647e00ef31ab0a3ff15217f8b90e295f051873a7) shows up when I select:

but not for the other addresses in this wallet.

I have the MaidSafeCoin crowdsale address as watch-only in the wallet. See the bold line below extracted from the History page. The two tx'es immediately above it (7.0, 3.0 MSC) are purchases sent to that address.

Full Wallet History for 1PKKRfHgvfZi2ToZDKkKrCUFpvuVKHz9WV

Transaction hash Currency Type Amount Transaction time 33dd53f3be3046f373648a... Mastercoin Simple send 0.001 02 Jul 14:33PM -0400 2cc239c25f45ac8970ecb1... Simple send Simple send 0.00000001 30 Jun 16:19PM -0400 1b4f9a748429a8a5f80e63... Mastercoin Simple send 1.48381952 20 Jun 09:56AM -0400 4a3d0bc6067116061ade8a... Mastercoin Simple send 50.01650753 13 Jun 02:00AM -0400 70b19b2973e297769a2f1c... Mastercoin Simple send 55.66610161 09 May 17:21PM -0400 0dad040e3dee92b32f3545... Test Mastercoin Simple send 55.66610161 08 May 19:44PM -0400 cce356a50eb626ff6ae071... Mastercoin Simple send 143.59489686 23 Apr 20:08PM -0400 1ddabb3f154f5857f2f0c1... Mastercoin Simple send 7.0 22 Apr 07:27AM -0400 febf421ce2fd8b93c9b975... Mastercoin Simple send 3.0 22 Apr 07:03AM -0400 86f214055a7f4f5057922f... MaidSafeCoin Fundraiser property creation 0 22 Apr 04:07AM -0400 221550a4799f37cd8a1822... Mastercoin Simple send 11.29317418 04 Apr 16:38PM -0400 da35c80b30063a8e3a4069... Mastercoin Simple send 66.30998258 04 Apr 15:53PM -0400 6f3683f2b710b6e3f9fde1... Mastercoin Simple send 11.29317418 17 Feb 19:56PM -0500 576cc185cece8eb9161fc7... Mastercoin Simple send 66.30998258 17 Feb 19:23PM -0500

ghost commented 10 years ago

I think my understanding of this is that you shouldn't see any watch-only data in the history - is that right?

marv-engine commented 10 years ago

The issue is that the page displays a tx (only 1 in this case) that does not involve the address I selected. Obviously, there are many other tx's that involve the MSafe crowdsale creation address. For some reason, only the tx51 shows up in the list for my address.

achamely commented 10 years ago

@faizkhan00 no, this has nothing to do with watch-only data.

The issue is that an address that has participated in a crowd sale (in this case maidsafe). Will display the original crowdsale creation tx in its history.

ghost commented 10 years ago

Actually, when I looked into this, it looked like Marv's address is erronenously associated with the creation of the crowdsale- this doesn't actually effect his balances, but there's still something wrong since the data is getting munged. We should see if there are any other instances and perhaps why it might be that this is still happening.

achamely commented 10 years ago

I can reproduce this with my maidsafe investment address as well.