Closed alanruttenberg closed 8 years ago
Done. Waiting for review from Jingshan.
The following ObjectProperties are still using the old prefix ncro-obo-WorkingVersion-######: IAO_0000117 has_integral_part homologous_to integral_part_of member_of non_functional_homolog_of part_of similar_to
Alan: Can u take care of bullets 2, 3, and 4 in my comment, and Harrison's comment as well?
Alan: Some more issues identified. Redundant relations: three "part_of" and two "has_part" - Need to remove redundant ones. Relation imported from BFO 1.1: "occurs in" - Can it be replaced with some OBO_REL relation? Relations "has output," "regulates," "negatively regulates," and "positively regulates" are imported from RO - Do they need to be replaced with some OBO_REL relation?
I will look at these. I noticed them as well an was planning to clean them up. Happy to hear that you are too and seeing the same issues I do :)
On Tue, Dec 1, 2015 at 3:50 PM Jingshan Huang notifications@github.com wrote:
Alan: Some more issues identified. Redundant relations: three "part_of" and two "has_part" - Need to remove redundant ones. Relation imported from BFO 1.1: "occurs in" - Can it be replaced with some OBO_REL relation? Relations "has output," "regulates," "negatively regulates," and "positively regulates" are imported from RO - Do they need to be replaced with some OBO_REL relation?
— Reply to this email directly or view it on GitHub https://github.com/OmniSearch/ncro/issues/2#issuecomment-161091436.
Another issue identified: there are some relations with ID like "OBO_REL#_adjacent_to" - do we wanna change to some equivalent relation ID without "#" OR leave as is?
We want to fix them
Ok.
(1) If a similar/equivalent relation is found that does not have "#", we simply import that relation. (2) Otherwise, are we able to change the ID of an imported relation?
Resolved in dea10b2fe109e566bf28ec1d321c7c4955d174e6
Guy: There are a total of five placeholders (high-level terms) described in our paper: ribosomal RNA (rRNA), transfer RNA (tRNA), long non-coding RNA (lncRNA), small nuclear RNA (snRNA), and small interfering RNA (siRNA). When you edit NCRO, please add them as direct children of the term “ncRNA.” Thanks!
Jingshan