ILinkedEditingRangeHandler should return a nullable result

OmniSharp / csharp-language-server-protocol

Language Server Protocol in C#

MIT License

521 stars 103 forks source link

ILinkedEditingRangeHandler should return a nullable result #644

Open allisonchou opened 3 years ago

allisonchou commented 3 years ago

The LSP spec indicates LinkedEditingRange can return either return LinkedEditingRanges or null. However, it seems like the O# ILinkedEditingRangeHandler expects a non-nullable response type: https://github.com/OmniSharp/csharp-language-server-protocol/blob/de1591e91a176fb88442ecf7e2e30f7a2174e6c0/src/Protocol/Features/Document/LinkedEditingRangeFeature.cs#L23

ToddGrun commented 3 years ago

I believe ICodeActionHandler and ICompletionHandler also have nullability issues

andyleejordan commented 3 years ago

I noticed a lot of warnings about nullability when I enabled the .NET Analyzer warnings. We could mark CS8764, CS8644, CS8619, and I'm sure others as errors and get them fixed.

allisonchou commented 2 years ago

Adding IDefinitionHandler to the list of interfaces needing nullability fixes