OmniSharp / omnisharp-atom

Omnisharp support for the atom editor
https://atom.io/packages/omnisharp-atom
MIT License
318 stars 61 forks source link

Arguments to CompositeDisposable.add must have a .dispose() method #1025

Open Eyap53 opened 6 years ago

Eyap53 commented 6 years ago

I try to use omniSharp-atom, but i always fail to activate the package.

I first run into the issue #1020 (and #1023 ).

I solved it thanks to @koxu1996 and @Skehmatics. Code :

replace l.140 by : var grammars = atom.grammars.textmateRegistry || atom.grammars;
and l.145 by : grammars.startIdForScope(grammar.scopeName);

But then i run into this other bug :

  1. Start atom with omnisharp disabled
  2. Try to enable it

Infos :

Atom: 1.25.0 x64 Electron: 1.7.11 OS: Ubuntu 16.04.4 Thrown From: omnisharp-atom package 0.31.2

Stack Trace

Failed to activate the omnisharp-atom package

At Arguments to CompositeDisposable.add must have a .dispose() method

TypeError: Arguments to CompositeDisposable.add must have a .dispose() method
    at assertDisposable (/usr/share/atom/resources/app/node_modules/event-kit/lib/composite-disposable.js:74:19)
    at CompositeDisposable.module.exports.CompositeDisposable.add (/usr/share/atom/resources/app/node_modules/event-kit/lib/composite-disposable.js:43:17)
    at Object.consumeProvider (/usr/share/atom/resources/app/node_modules/autocomplete-plus/lib/main.js:89:27)
    at Object.consumeProvider_2 (/usr/share/atom/resources/app/node_modules/autocomplete-plus/lib/main.js:62:23)
    at Provider.module.exports.Provider.provide (/usr/share/atom/resources/app/node_modules/service-hub/lib/provider.js:34:58)
    at ServiceHub.module.exports.ServiceHub.provide (/usr/share/atom/resources/app/node_modules/service-hub/lib/service-hub.js:30:26)
    at Package.activateServices (/usr/share/atom/resources/app/src/package.js:397:75)
    at Package.activateNow (/usr/share/atom/resources/app/src/package.js:233:20)
    at measure (/usr/share/atom/resources/app/src/package.js:206:33)
    at Package.measure (/usr/share/atom/resources/app/src/package.js:88:25)
    at activationPromise.Promise (/usr/share/atom/resources/app/src/package.js:200:20)
    at Promise (<anonymous>)
    at Package.activate (/usr/share/atom/resources/app/src/package.js:198:38)
    at PackageManager.activatePackage (/usr/share/atom/resources/app/src/package-manager.js:695:42)
    at packagesToEnable.forEach.name (/usr/share/atom/resources/app/src/package-manager.js:440:51)
    at Array.forEach (native)
    at disabledPackagesSubscription.config.onDidChange (/usr/share/atom/resources/app/src/package-manager.js:440:30)
    at emitter.on (/usr/share/atom/resources/app/src/config.js:1023:22)
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app/node_modules/event-kit/lib/emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app/node_modules/event-kit/lib/emitter.js:141:34)
    at Config.emitChangeEvent (/usr/share/atom/resources/app/src/config.js:1175:62)
    at Config.setRawValue (/usr/share/atom/resources/app/src/config.js:1008:23)
    at Config.set (/usr/share/atom/resources/app/src/config.js:711:18)
    at Config.removeAtKeyPath (/usr/share/atom/resources/app/src/config.js:901:16)
    at Package.enable (/usr/share/atom/resources/app/src/package.js:75:30)
    at PackageManager.enablePackage (/usr/share/atom/resources/app/src/package-manager.js:246:18)
    at HTMLButtonElement.enablementButtonClickHandler (/usr/share/atom/resources/app/node_modules/settings-view/lib/package-card.js:362:31)

Non-Core Packages

atom-beautify 0.32.2 
busy-signal 1.4.3 
file-icons 2.1.19 
highlight-selected 0.13.1 
intentions 1.1.5 
language-haml 0.31.0 
linter 2.2.0 
linter-ui-default 1.7.1 
minimap 4.29.8 
minimap-cursorline 0.2.0 
minimap-highlight-selected 4.6.1 
omnisharp-atom 0.31.2 
pigments 0.40.2 

Any idea how to solve this ?