Flycheck requires omnisharp-start-omnisharp-server (roslyn branch)

rokadias commented 8 years ago

So I've been running omnisharp-roslyn and it's been great. (Thanks!) The biggest issue that I've run into is trying to run omnisharp-start-omnisharp-server and after a while my emacs comes to a crawl. I have to assume it's the memory used by Omnisharp-Roslyn executable on mono. So I'd like to switch to running omnisharp in a different process. I've (setq omnisharp-use-http t), but the existing flycheck predicate is checking for the omnisharp--server-info.

I'll have a pull request for what I've done. Which is that I've just modified the predicate to ignore the server info if omnisharp-use-http is set, but I assume this could create issues if someone has the omnisharp-use-http set, but their http omnisharp server goes down. I am personally OK with that since you've just caused your own performance issues. Otherwise the predicate would have to check alive status pretty regularly which could be too much overhead.

doomchild commented 7 years ago

I've made the same change you did, but now flycheck gives me an error saying

Blocking call to accept-process-output with quit inhibited!!

Have you seen this problem? Flycheck shows the checker as existing, but I get none of the regular Flycheck stuff for syntax errors and the like.

razzmatazz commented 7 years ago

@doomchild do you still have this problem?

there has lately been a new version of omnisharp-emacs released which maybe have fixed your problem.

although not many people use http transport nowadays, I am not 100% sure

doomchild commented 7 years ago

Having upgraded my version of the omnisharp from MELPA, I'm not seeing the error I listed above anymore. However, I'm not getting any flycheck errors popping up where they should, either.

razzmatazz commented 7 years ago

@doomchild

do you have autocompletion working though?
do you have flycheck mode enabled for the buffer (via mode hook or manually?) what is the contents of your csharp-mode-hook?
if not, could you try loading the MinimalProject.csproj from https://github.com/OmniSharp/omnisharp-emacs/tree/master/test/MinimalProject, and check if autocomplete, or flycheck works for you?
what is your platform?

OmniSharp / omnisharp-emacs

Flycheck requires omnisharp-start-omnisharp-server (roslyn branch) #250