search

OmniSharp / omnisharp-emacs

Troll coworkers - use Emacs at work for csharp!
GNU General Public License v3.0
514 stars 90 forks source link

Helm get symbols timeout to short #355

Open ihdavids opened 7 years ago

ihdavids commented 7 years ago

Any chance we can make a global default for the timeout-seconds in here in omnisharp-utils? Or provide a means of piping a timeout value through in the symbols-candidates method?

In any project of reasonable size I find I am bumping into the timeout here when using omnisharp-helm-find-symbols:

omnisharp-helm-find-symbols omnisharp--helm-find-symbols-candidates omnisharp--send-command-to-server-sync

omnisharp--wait-until-request-completed (timeout happens in here)

Here is the actual timeout:

(defun omnisharp--wait-until-request-completed (request-id &optional timeout-seconds) (setq timeout-seconds (or timeout-seconds 2))

razzmatazz commented 7 years ago

Yes we can fix this fairly easily I think. The underlying issue is in omnisharp Roslyn server where the implementation is a little bit naive. Increasing the timeout should be a quick fix for now..

ihdavids notifications@github.com schrieb am Di., 15. Aug. 2017, 17:43:

Any chance we can make a global default for the timeout-seconds in here in omnisharp-utils? Or provide a means of piping a timeout value through in the symbols-candidates method?

In any project of reasonable size I find I am bumping into the timeout here when using omnisharp-helm-find-symbols:

omnisharp-helm-find-symbols omnisharp--helm-find-symbols-candidates omnisharp--send-command-to-server-sync

omnisharp--wait-until-request-completed (timeout happens in here)

Here is the actual timeout:

(defun omnisharp--wait-until-request-completed (request-id &optional timeout-seconds) (setq timeout-seconds (or timeout-seconds 2))

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OmniSharp/omnisharp-emacs/issues/355, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiZZFB3LuDf-Eu3YXu6FYA2FeckM3yXks5sYi0rgaJpZM4O4Pm_ .

razzmatazz commented 7 years ago

@ihdavids btw, what kind of timeout would you seem reasonable? have you experimented to check what timeout value works for you best?