search

OmniSharp / omnisharp-node-client

node client for the omnisharp-roslyn server
http://www.omnisharp.net/
MIT License
52 stars 19 forks source link

Update omnisharp-node-client for using the latest omnisharp-roslyn binary #435

Open AndrienkoAleksandr opened 7 years ago

AndrienkoAleksandr commented 7 years ago

Inside Eclipse CHE we are using omnisharp-node-client language server. I see that the latest release works with dotnet 1.0.4 projects, but it doesn't work with dotnet 2.0. Can you update this omnisharp-node-client to the latest omnisharp-roslyn binary, (seems it should resolve this problem)?

mickaelistria commented 7 years ago

It also seems like the current version in omnisharp-node-client does embed a version of OmniSharp-Roslyn with the following issue: https://github.com/OmniSharp/omnisharp-vscode/issues/786 .

david-driscoll commented 7 years ago

I'll jump on it this weekend!

mickaelistria commented 7 years ago

Which version/commit of omnisharp-roslyn does bring support for dotnet 2.0? Omnisharp-node-client currently uses omnisharp-roslym 1.22 which seems to be the latest release. Is the upcoming 1.23 going to provide full support for dotnet 2.0 ? What would be the prerequisites for it to work on Linux?

david-driscoll commented 7 years ago

1.23.1 should work with the latest dotnet core 2.0. I'll be pushing an update with the related fixes tonight.

mickaelistria commented 7 years ago

Hurray! I tried the latest release v7.1.2 which uses omnisharp-roslyn 1.23.1 and it worked well on Fedora 26 with a version recent of dotnet-core 2.0 and no dependency on mono! I believe it's a pretty satisfying result from integrator and user POV, so we can close this issue. Thanks for your assistance!