search

OmniSharp / omnisharp-scaffolding

MIT License
12 stars 7 forks source link

Completion of initial next steps (omnisharp/omnisharp-scaffolding#1) #2

Closed dmccaffery closed 8 years ago

dmccaffery commented 8 years ago

Removed all projects except CodeGeneration, which was renamed to OmniSharp.Scaffolding Dependencies are now pulled in through NuGet Ensured KoreBuild continues to work Building against latest available DNX sources and dependencies Changed the license from Apache 2.0 to MIT (per OmniSharp standard) Added a new, empty test project for unit tests Updated the readme.md to elaborate on what OmniSharp.Scaffolding now is and what its future goals are.

itomek commented 8 years ago

It look like you are using JetBrains [NotNull] annotations. Will we be using Resharper for this?

Muchiachio commented 8 years ago

It was forked before aspnet team did a [NotNull] removal, I guess it's just a legacy now.

sayedihashimi commented 8 years ago

FYI I won't be able to review for about a week as I'm on vacation.

If you get a :+1: from @Muchiachio then go ahead and merge.

Muchiachio commented 8 years ago

@dmccaffery I guess we should remove [NotNull] attributes as it relies on a paid product. Other than that :shipit:

itomek commented 8 years ago

Well we could get Resharper OpenSource licenses of course but that would take time.

dmccaffery commented 8 years ago

My apologies to those who got assigned to this by accident; there is a bug in github on mobile devices where touches do not register correctly when attempting to make an assignment... :(

david-driscoll commented 8 years ago

That's a ton of stuff, but looks good :shipit: