Closed fishg closed 6 years ago
It's because code checks are not called on save now
On Thursday, 9 April 2015, fishg notifications@github.com wrote:
The problem I found was no error message showed on save a cs file with some error. eg: Error : 'String' is not a known identifier - (14, 15)
hot check is fine out put the error message,but on save none message tips. [image: image] https://cloud.githubusercontent.com/assets/1423545/7061783/99b3cb86-dec8-11e4-8cef-b84922df8247.png [image: image] https://cloud.githubusercontent.com/assets/1423545/7061784/a1d39954-dec8-11e4-9950-aa52cc98ccd2.png
[image: image] https://cloud.githubusercontent.com/assets/1423545/7061776/7e363f60-dec8-11e4-8a65-b12f7cbe499b.png
Reply to this email directly or view it on GitHub https://github.com/OmniSharp/omnisharp-sublime/issues/162.
@jchannon But if an syntax will get error message on save:
Actually I'm getting something strange with this, too. I'll start looking at the last few commits. I get the "file added to project" instead of a response to the request for syntax checking often.
/addtoproject is called when a file is saved so it adds to the csproj
On Monday, 13 April 2015, Karl Gluck notifications@github.com wrote:
Actually I'm getting something strange with this, too. I'll start looking at the last few commits. I get the "file added to project" instead of a response to the request for syntax checking in some situations also.
Reply to this email directly or view it on GitHub https://github.com/OmniSharp/omnisharp-sublime/issues/162#issuecomment-92499569 .
It appears that /addtoproject
obliterates the results of /codecheck
. Repeatedly calling save on a file when /addtoproject
is called results in empty responses about 80% of the time. Here's a log (with personal data trimmed out):
======== request ========
Url: http://localhost:51093/addtoproject
Data: {...}
======== request ========
Url: http://localhost:51093/codecheck
Data: {...}
======== response ========
true
file added to project
True
======== end ========
======== response ========
response is empty
handling Errors
no data
======== end ========
======== request ========
Url: http://localhost:51093/addtoproject
Data: {...}
======== request ========
Url: http://localhost:51093/codecheck
Data: {...}
======== response ========
true
file added to project
True
======== end ========
======== response ========
response is empty
handling Errors
no data
======== end ========
Whereas when /addtoproject
is disabled, it works consistently:
======== request ========
Url: http://localhost:51023/codecheck
Data: {"buffer": "..."}
======== response ========
{"QuickFixes":[]}
handling Errors
======== end ========
======== request ========
Url: http://localhost:51023/codecheck
Data: {"buffer": "..."}
======== response ========
{"QuickFixes":[]}
handling Errors
======== end ========
======== request ========
Url: http://localhost:51023/codecheck
Data: {"buffer": "..."}
======== response ========
{"QuickFixes":[]}
handling Errors
======== end ========
======== request ========
Url: http://localhost:51023/codecheck
Data: {"buffer": "..."}
======== response ========
{"QuickFixes":[]}
handling Errors
======== end ========
======== request ========
Url: http://localhost:51023/codecheck
Data: {"buffer": "..."}
======== response ========
{"QuickFixes":[]}
handling Errors
======== end ========
That is odd
Closing due to inactivity.
The problem I found was no error message showed on save a cs file with some error. eg: Error : 'String' is not a known identifier - (14, 15)
hot check is fine out put the error message,but on save none message tips. hot check:
on save:
on save console log: