search

OmniSharp / omnisharp-vim

Vim omnicompletion (intellisense) and more for C#
http://www.omnisharp.net
MIT License
1.7k stars 169 forks source link

OmniSharpInstall currently broken because latest release doesn't have downloads for the various platforms #766

Open PMunch opened 2 years ago

PMunch commented 2 years ago

Tried to run OmniSharpInstall today and it didn't work, just complained that it couldn't unzip the file. Looking at the file it was obvious why, it simply contained a single line of normal text reading "Not Found". Reading through the helper script and trying to run the commands I quickly found out that the issue is that the latest release (v1.38.2) doesn't have assets following the naming conventions. Apparently curl doesn't set an error code, it just writes an error to the file by default. The -f flag should be added to the curl call to allow it to fail with an error code so that the appropriate error could be triggered in the script.

Oh, and someone should probably fix the OmniSharp release to have all the assets, not sure if this is just a CI thing where they will be added once they are done, but for now at least it is broken.

nickspoons commented 2 years ago

@PMunch apparently there's an issue with a nuget key, which is causing the broken release. In the meantime, the previous version of the server can be installed with :OmniSharpInstall v1.38.1

Yes, some sensible error warnings during the install process would be nice, if anyone wants to do the work.

nickspoons commented 2 years ago

The issue is resolved, the release assets are available now

PMunch commented 2 years ago

I think this issue should be kept open (or another one created) for the part where the script isn't able to detect the failed download when using curl. The script has a "couldn't download" error block, but this is never entered as curl by default doesn't set an error return code.

justonia commented 1 year ago

Worth noting I had to use 1.38.1 to get this to work on WSL1 + Unity.

cachandlerdev commented 1 year ago

Has there been any update on this issue? It seems like we still have to install 1.38.1.

nickspoons commented 1 year ago

What issue? The issue is that sometimes the build assets are missing on omnisharp-roslyn releases. That is not the case currently, the v1.39.7 assets are available.

Why would you have to install 1.38.1?

cachandlerdev commented 1 year ago

Unfortunately, I've been having a bit of difficulty trying to correctly setup this plugin. I can successfully run :OmniSharpInstall, but something seems to be going wrong because I keep getting the message "The OmniSharp server does not appear to be installed. Would you like to install it?" every time I restart vim, and it never actually starts working after the installation.

I also have an issue where the omnisharp log reports failing to open most of the files due to missing assembly references, but perhaps that falls under one of the other Github issue pages.

nickspoons commented 1 year ago

This is not related to this issue, let's discuss it in #841