search

OmniSharp / omnisharp-vim

Vim omnicompletion (intellisense) and more for C#
http://www.omnisharp.net
MIT License
1.72k stars 168 forks source link

Use the correct buffer when applying fixusings #821

Closed nickspoons closed 2 years ago

nickspoons commented 2 years ago

Fixes #817

Melandel commented 2 years ago

It works, however it leaves the command line focused, so either I have to type <CR>, either a movement (j or G for instance), which happens to trigger E20: Mark not set

Edit: I can do silent cfdo OmniSharpFixUsings but it'd be nice if cfdo OmniSharpFixUsings did not force a <CR> in the workflow

Edit2: set cmdheight=2 works as well

Edit3: this issue is inherent to cfdo and not to Omnisharp.

Melandel commented 2 years ago

Another detail is that I have both my buffers with unnecessary usings displayed in the same tab, and ALE yellow warnings signs do not update

nickspoons commented 2 years ago

OK I can see that there are tweaks that could be made to the actual :cfdo OmniSharpFixUsings flow, but this PR is good as it is, it's a simple and sensible improvement, so I'll merge it.

I'm not sure if the ALE thing is something that OmniSharp-vim should be handling, or if it's a workflow issue.