OmniSharp / omnisharp-vim

Vim omnicompletion (intellisense) and more for C#
http://www.omnisharp.net
MIT License
1.72k stars 168 forks source link

Added option to enable snippet support for coc completion source. (STDIO only for now) #830

Closed lubyrex closed 1 year ago

lubyrex commented 1 year ago

Hi! First of all, thanks for the amazing plugin! It has helped me a ton in my daily work.

Three months ago, I submitted an issue: #808 on omnisharp-vim not supporting snippet when used with coc. And it seems like that's because coc does not support vim source having snippets back then. But now it has added this feature with this commit: snippet support for vim source, and I have been playing around with omnisharp-vim's completion methods to try to add snippet support. So far, it is working great for me, which is why I have created a pull request other people can try as well. Could you please take a look and let me know if you would be interested in adding this support and if you have any comments or suggestions for my pull request?

I have also made a gif to show what it looks like after the change: coc_snippet_demo

lubyrex commented 1 year ago

@microsoft-github-policy-service agree

nickspoons commented 1 year ago

This is great, thanks @lubyrex!