search

OmniSharp / omnisharp-vim

Vim omnicompletion (intellisense) and more for C#
http://www.omnisharp.net
MIT License
1.72k stars 168 forks source link

Rename fails with struct parameters #862

Closed Chris-Collett closed 5 months ago

Chris-Collett commented 5 months ago

I have a struct such as:

    public record struct DeviceCoordinates(
        Coordinates<Counts> Raw,
        Coordinate<Meters> Absolute
    );

If I try to rename "Absolute" to "FromOrigin", only places that initialize a new DeviceCoordinates struct will see the change. Any places where the "Absolute" value is accessed are not renamed.

My omnisharp version (from the .exe, not sure where to find the version otherwise) is "1.39.10". I'm using it in neovim.

nickspoons commented 5 months ago

This code action is performed by the server, all we do in OmniSharp-vim is send the rename request, and update the affected buffers/files according to the response we receive. In this case the server isn't sending updates for the record fields.

I recommend opening an issue with OmniSharp-roslyn