Open willu47 opened 4 years ago
Is it required to store the intermediate values (in this case classification values) in the DataFrame, which is then written out, or could just the final penalty be stored?
https://github.com/OnSSET/onsset/blob/388ae1cacd5d507c545096a17360bacb1e4bee84/onsset/onsset.py#L703-L730
If not, then this code could be simplified considerably and turned into a more self-contained and testable function.
Is it required to store the intermediate values (in this case classification values) in the DataFrame, which is then written out, or could just the final penalty be stored?
https://github.com/OnSSET/onsset/blob/388ae1cacd5d507c545096a17360bacb1e4bee84/onsset/onsset.py#L703-L730
If not, then this code could be simplified considerably and turned into a more self-contained and testable function.