OnTrack-UG-Squad / speaker-verification-api

A public repository of work for the Speech Verification RESTful API component of the undergrad squad for Doubtfire.
MIT License
2 stars 5 forks source link

Integrate Redis and Celery #3

Closed namvnngu closed 3 years ago

namvnngu commented 3 years ago

Files changed:

Files created:

Please comment feedback below for further improvements.

Ref issue #1

notkurt commented 3 years ago

Hey @nnfunny - Great job with integrating Celery and Redis into the project, however I noticed that you didn't update the sample environment files to accomodate for new environment variables. In addition I feel as if the Redis health-check URL could be a bit more specific, such as redis-healthcheck. Happy to hear your thoughts on URL health check URL.

namvnngu commented 3 years ago

Hi @notkurt, I updated the environment variables and the health-check URL according to your good suggestions. If you need to test Celery, I can suggest you one article I read Setting up an asynchronous task queue for Django using Celery and Redis. I'd love to hear feedback from you. Cheers.

notkurt commented 3 years ago

Premature merge, however everything is all good on your end. @nnfunny - Tested with no issues. Great job!