OncleMoon / jodconverter

Automatically exported from code.google.com/p/jodconverter
0 stars 0 forks source link

Adopt Sigar library for process management #82

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Sigar "provides a portable interface for gathering system information" with 
native libraries for many OSes

  http://support.hyperic.com/display/SIGAR/Home

would almost certainly be better than the current simple ProcessManager 
implementations.

Looked at it in the past but discarded due to its license; however it's now 
available under the Apache Licence v2.0.

Original issue reported on code.google.com by mirko.na...@gmail.com on 13 Mar 2011 at 4:00

GoogleCodeExporter commented 9 years ago
Hi Mirko.

I have started on this refactor.
Can you have a look here 
http://groups.google.com/group/jodconverter/browse_thread/thread/1229e1745d6d021
5

Would be great to get write access to a branch of trunk

Original comment by shervin.asgari@gmail.com on 14 Mar 2011 at 1:38

GoogleCodeExporter commented 9 years ago

Original comment by shervin.asgari@gmail.com on 14 Mar 2011 at 7:39

GoogleCodeExporter commented 9 years ago
Sigar is not implemented and ready for testing.
The latest commit breaks the API. I removed the old ProcessManager and 
implemented a new one, (SigarProcessManager).

If you want to test the old unbreakable API, you need to checkout revision 171, 
which basically is the same sigar code.

Original comment by shervin.asgari@gmail.com on 21 Mar 2011 at 2:06

GoogleCodeExporter commented 9 years ago
It should say "Sigar is NOW implemented".

Original comment by shervin.asgari@gmail.com on 22 Mar 2011 at 8:09

GoogleCodeExporter commented 9 years ago
Setting newly-added status "FixedInBranch" to be able to tell what still needs 
to be merged into trunk.

Original comment by mirko.na...@gmail.com on 27 Mar 2011 at 11:13

GoogleCodeExporter commented 9 years ago

Original comment by mirko.na...@gmail.com on 27 Mar 2011 at 1:12

GoogleCodeExporter commented 9 years ago
Maven can't find the Sigar artifacts; do we need to add a repository?

Downloading: 
http://repo1.maven.org/maven2/org/hyperic/sigar-dist/1.6.5.132/sigar-dist-1.6.5.
132.zip
[WARNING] An error occurred during dependency resolution.
    Failed to retrieve org.hyperic:sigar-dist-1.6.5.132
Caused by: Could not find artifact org.hyperic:sigar-dist:zip:1.6.5.132 in 
central (http://repo1.maven.org/maven2)

Original comment by mirko.na...@gmail.com on 27 Mar 2011 at 1:37

GoogleCodeExporter commented 9 years ago
Aah thats too bad. I have in my .m2 settings also included the jboss 
repostitory: https://repository.jboss.org/nexus/index.html

It is included there. Perhaps that's why it worked out of the box for me.
Can we ask to include sigar in the maven central? Or is it ok to refer to the 
jboss rep?

Original comment by shervin.asgari@gmail.com on 27 Mar 2011 at 1:44

GoogleCodeExporter commented 9 years ago
I think we can add the jboss repo to the project pom.xml.

Original comment by mirko.na...@gmail.com on 27 Mar 2011 at 1:48

GoogleCodeExporter commented 9 years ago
Good idea. Do you want to do that right away?

Original comment by shervin.asgari@gmail.com on 27 Mar 2011 at 2:02

GoogleCodeExporter commented 9 years ago
I can add it as part of the merge - the main thing was finding out which repo 
was needed. Should be

    <repository>
      <id>jboss-public-repository-group</id>
      <url>https://repository.jboss.org/nexus/content/groups/public-jboss/</url>
    </repository>

according to http://community.jboss.org/wiki/MavenGettingStarted-Users

Original comment by mirko.na...@gmail.com on 27 Mar 2011 at 2:32

GoogleCodeExporter commented 9 years ago
Great. Looks right the correct URL.

Original comment by shervin.asgari@gmail.com on 27 Mar 2011 at 2:45

GoogleCodeExporter commented 9 years ago
When running mvn test on the shell, I get 
INFO: connected: 'socket,host=127.0.0.1,port=8100,tcpNoDelay=1'
Mar 28, 2011 1:14:56 PM org.artofsolving.jodconverter.office.OfficeProcess 
forciblyTerminate
INFO: trying to forcibly terminate process: 
'socket,host=127.0.0.1,port=8100,tcpNoDelay=1' (pid 0)
Killed

But when running mvn test through eclipse, I don't get this and everything runs 
fine.
I am a bit worried about this. Do you know why it is killed like this? 

Original comment by shervin.asgari@gmail.com on 28 Mar 2011 at 11:18

GoogleCodeExporter commented 9 years ago

Original comment by mirko.na...@gmail.com on 3 Apr 2011 at 12:32