search

OndrejHome / fast-vm

'fast-vm' is a script for defining VMs from images provided in thin LVM pool.
GNU General Public License v3.0
22 stars 14 forks source link

Image name cannot end with -XX (number) #44

Open micharbet opened 6 years ago

micharbet commented 6 years ago

I tried to import fedora image: 

#  fast-vm import_image fedora-28 http://ftp.linux.cz/pub/linux/people/ondrej_famera/fastvm-images/generated/6g__fedora-28.img.xz https://raw.githubusercontent.com/OndrejHome/fast-vm-public-images/develop/fedora/xml/fedora-28.xml https://raw.githubusercontent.com/OndrejHome/fast-vm-public-images/develop/fedora/hacks/6g_fedora-28-hacks.sh
[__][err] ImageName cannot end with '-XX' where XX is number.

I could do it when I change image name from fedora-28 to e.g. fedora-2.8 But this is just wrong. Please kindly remove this limitation.

-michael-

OndrejHome commented 6 years ago

Hi Michael,

This works as designed as there are currently some patters that are internally used by fast-vm for its functionality. I can try to check if there is way to have "visible name" ending with -XX and let you know.

OndrejHome commented 4 years ago

I will be having look at this for next version as I think there is a way how to tell apart the image LVs and VM LVs without need to have special name - I can distinguish the LVs based on 'origin' field in lvs which is empty for images and present for VMs.