search

OndrejKunc / flutter_dynamic_forms

A collection of flutter and dart libraries allowing you to consume complex external forms at runtime.
MIT License
204 stars 60 forks source link

Added Date Range Picker. #50

Closed kalismeras61 closed 5 years ago

kalismeras61 commented 5 years ago

I added custom date range picker. I hope everytings ok :) Check it out.

OndrejKunc commented 5 years ago

Hi @kalismeras61 , Thanks for the merge request, it looks like you put a lot of effort into it!

Overall I really like this component. I found two issues though:

  1. There is some bug when computing dates. See the screenshot below. The date 27 is duplicated on both monday and sunday. There is also a white space between 27 and 28. I guess you tested it on your locale which is different than English so you didn't notice it.

Screenshot_20191026-193221

  1. When you already select some range and you want to extend it works perfectly. The problem comes when you need to make the date range shorter - when you click in between the already selected dates nothing happens. You need to click on the circle to cancel the selection and then click again. I think this is not very user-friendly, because it is hard to guess that you have to click on the circle. I understand that if you select range 1 - 10 and you click on the number 7 you would need to choose if the result should be 1 - 7 or 7 - 10. I think one solution can be that you cancel the selection and only select the number 7 as the start date. What do you think?

Also it looks like your branch has some conflicts so I can't merge it. I think you need to update your fork with my master branch.

kalismeras61 commented 5 years ago

Hi @OndrejKunc ,

Thanks for your feedbacks. I could not respond immediately because it is an official holiday in my Country. The first problem for my local language in English and both iOS and android side have not encountered this problem. I've seen it for the first time and I don't know what it is and I'm not sure how to test it. Do you have another idea?

Date Range For the second problem, I am aware that it is best to cancel the selection and re-select it. I will update as soon as possible.

kalismeras61 commented 5 years ago

I fixed second problem. But again i didn't see any error for first error. :(

OndrejKunc commented 5 years ago

Thanks again for the awesome component! I will publish it probably tomorrow.

kalismeras61 commented 5 years ago

Thanks again for the awesome component! I will publish it probably tomorrow.

Your welcome. I hope it will help someone!.