OndrejSladky / fmsi

FMSI is an exact f-masked-superstrings-based index for membership queries and set operations on k-mer sets.
MIT License
9 stars 2 forks source link

Fix local sdsl compilation #5

Closed karel-brinda closed 1 year ago

OndrejSladky commented 1 year ago

The previous approach did not work? I.e. did you try running ./src/sdsl-lite/install.sh (this is the recommended installation of SDSL) and then make? (Sorry that I haven't written documentation yet.)

At least on linux the previous approach had the advantage that one didn't have to give it administrator privileges in order to run (which for example means that I won't be able to run it on our linux servers).

karel-brinda commented 1 year ago

I had the following issues:

  1. SDSL installation was not integrated in the Make workflow
  2. install.sh was a bit slow as it always used Make with 1 thread
  3. It was requiring an installation of SDSL into my home directory (~/include -L~/lib) rather than staying inside the repo.
OndrejSladky commented 1 year ago

Good to know. Issues 1 and 3 can be trivially solved using install. I'll see whether 2 can be solved using install or whether I can modify the make not to require administrator rights.

karel-brinda commented 1 year ago

In fact, I actually just extracted the relevant commands from the install.sh script and put them into Makefile

OndrejSladky commented 1 year ago

Oh, it turned out the mistake was mine -- the installation requires (for some reason) admin privileges whenever the library is installed elsewhere.