search

OndrejSladky / kmercamel

KmerCamel🐫 provides implementations of several algorithms for efficiently representing a set of k-mers as a masked superstring.
MIT License
11 stars 2 forks source link

Kmercamel should fail when non-sense parameters are used #34

Closed karel-brinda closed 1 year ago

karel-brinda commented 1 year ago

For instance, when -d is provided for greedy or greedyAC. This is important for the subsequent pipeline development (to figure out immediately that a invokes the program with the wrong params).

GordonHoklinder commented 1 year ago

You're right, it's fixed now. The only thing that passes and does not make very much sense is d > k. But as we've discussed previously, it might make sense to allow it and cap it at d (iirc which is what is being done now).

karel-brinda commented 1 year ago

The only thing that passes and does not make very much sense is d > k. , it might make sense to allow it and cap it at d

Agree. Thanks for the update.