search

OndrejSladky / kmercamel

KmerCamel🐫 provides implementations of several algorithms for efficiently representing a set of k-mers as a masked superstring.
MIT License
11 stars 2 forks source link

Version #46

Closed OndrejSladky closed 11 months ago

OndrejSladky commented 11 months ago

Version is now automatically updated after every single commit.

karel-brinda commented 11 months ago

Looks good, just the version of the hash is just a bit too long. I think 6 characters should be enough (already for this the prob of a collision should be very low).

btw. in the current implementation, which version will appear in "true" releases (I just remember this is what I was always struggling with a couple of ys ago)?

OndrejSladky commented 11 months ago

btw. in the current implementation, which version will appear in "true" releases (I just remember this is what I was always struggling with a couple of ys ago)?

I'm not entirely sure what is the question. But if it is which versions will have separate tag on gh, then I was thinking I'd make it every 0.x version. Or do you have any other sugestions?

karel-brinda commented 11 months ago

When you release a New version, will it be something like 0.3 or 0.3-348a841 ? For the actual releases the version should be the former

On Tue, Oct 3, 2023 at 8:51 PM Ondřej Sladký @.***> wrote:

btw. in the current implementation, which version will appear in "true" releases (I just remember this is what I was always struggling with a couple of ys ago)?

I'm not entirely sure what is the question. But if it is which versions will have separate tag on gh, then I was thinking I'd make it every 0.x version. Or do you have any other sugestions?

— Reply to this email directly, view it on GitHub https://github.com/OndrejSladky/kmercamel/pull/46#issuecomment-1745537444, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACC7KJSSGUSV44UFQ6TW7TTX5RNBNAVCNFSM6AAAAAA5RIUE5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVGUZTONBUGQ . You are receiving this because your review was requested.Message ID: @.***>

OndrejSladky commented 11 months ago

The way it is now, it'll display 0.3-348a841. If you think this is not good enough, i'll file another issue and will think about how to elegantly fix this.

karel-brinda commented 11 months ago

In case it's a new release, it should be just 0.3. I'm not sure how it's doable, but it somehow should be as a I often see it in software packages.

karel-brinda commented 11 months ago

btw. see also:

karel-brinda commented 11 months ago

Actually $ git describe --abbrev=4 --dirty --always --tags v0.1.0 seems to be working really well!!!!! When it's a release, it prints just eg v0.1.0.

So it just needs to be included somehow in the Makefile – as the first step of compilation, this string should be generated.

One difficulty I see is that it make should be able to compile it even out of git without a failure.