search

Ondsel-Development / FreeCAD

This is the official source code of FreeCAD, a free and opensource multiplatform 3D parametric modeler.
https://www.freecad.org
Other
148 stars 7 forks source link

Malformed unicode characters in Sketcher Expression editor #101

Open ekenberg opened 4 weeks ago

ekenberg commented 4 weeks ago

Is there an existing issue for this?

Problem description

Sketcher: Named constraints with unicode characters (in this case Swedish åäö) seem to work well, except for suggested completions in the Expression editor. Please see attached screenshot. Using one of the suggested paths results in an error. However, typing the correct path manually works as expected.

Full version info

OS: Linux Mint 21.3 (X-Cinnamon/cinnamon)
Word size of Ondsel: 64-bit
Version: 2024.2.1.37226 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 2024.2.1)
Hash: 1a1bd7290494aef925a026c87b808ac58d53c3b0
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: English/United States (en_US)
Installed mods: 
  * fasteners 0.5.24
  * Ondsel-Lens 2024.5.6.01

Subproject(s) affected?

Sketcher

Anything else?

expression_editor_constraints

Code of Conduct

prokoudine commented 3 weeks ago

This is likely an upstream bug.

@PaddleStroke, @pieterhijma

101, #102 amd #105 seem related to each other, at least the first two?

PaddleStroke commented 3 weeks ago

I also think it is probably a upstream bug. Unless it's a change by @pieterhijma ?

pieterhijma commented 3 weeks ago

In my opinion, (as commented here, this is an upstream bug. Sketcher optional names for constraints should not allow unicode characters, because they are effectively identifiers.

@ekenberg, I recommend creating an issue upstream. I can do that as well if you prefer.

ekenberg commented 3 weeks ago

@pieterhijma if you wouldn't mind creating the upstream issue, I think that might be more efficient. If there are any questions or arguments, you will be more suited to answering. Thanks a lot for looking into this.