search

Ondsel-Development / FreeCAD

This is the official source code of FreeCAD, a free and opensource multiplatform 3D parametric modeler.
https://www.freecad.org
Other
192 stars 8 forks source link

Bughunt-1.0 VarSet : Unable to create a title in another language #105

Closed free777cat closed 4 months ago

free777cat commented 4 months ago

Is there an existing issue for this?

Problem description

It is not possible to create a name in Ukrainian Зняток екрана як 2024-06-27 20-00-34

Full version info

OS: Linux Mint 22 (MATE/mate)
Word size of Ondsel: 64-bit
Version: 2024.2.0dev.37914 (Git) AppImage
Build type: Release
Branch: flavor
Hash: 88e76e1d516654ee4a020cf4ad676853ca4d2f31
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: Ukrainian/Ukraine (uk_UA)
Installed mods: 
  * Ondsel-Lens 2024.1.22.01
  * sheetmetal 0.4.20

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct

prokoudine commented 4 months ago

@pieterhijma Are properties ASCII-only in FreeCAD by design?

free777cat commented 4 months ago

It works here Зняток екрана як 2024-06-30 19-03-10

It doesn't work here Зняток екрана як 2024-06-30 18-56-12

free777cat commented 4 months ago
  1. Good -----> Unicode
  2. Bad -----> ASCII
pieterhijma commented 4 months ago

Thank you for reporting! Properties can only contain ASCII characters (digits, uppercase and lowercase letters, and underscore). I believe the reason is that they should be used as expressions as well. The optional Sketcher name for the constraints allows unicode characters as input and that seems to me a bug. @free777cat, do you want to create an issue in upstream FreeCAD? I can do this as well if you prefer.

free777cat commented 4 months ago

Do you want to remove UNICODE?

free777cat commented 4 months ago

To be honest, I don't really like that you can't use your own language :((

pieterhijma commented 4 months ago

@free777cat, sorry, my explanation may be a bit unclear. Let me try to clarify: Currently in FreeCAD and Ondsel ES, properties can only consist of ASCII characters. The Sketcher allows Unicode characters as input for named constraints, but this is not aligned with the restriction in FreeCAD and Ondsel ES that defines that properties can only consist of ASCII characters. In that sense, Sketcher has a bug and it should be resolved. So, Sketcher should not allow unicode characters as input for named properties.

However, I fully understand that you would like to be able to create properties with unicode characters. This would not be a bug, but a feature request. I don't think it is very difficult to support this in FreeCAD and I would invite you to create an issue in FreeCAD asking for the feature to support unicode as properties.

free777cat commented 4 months ago

I will be grateful if you create this "issue".

sliptonic commented 4 months ago

My read of the discussion is that there are two separate issues. One is a potential bug with sketches. The other is a feature request. @pieterhijma let's open the bug report upstream. @free777cat If you want to pursue the feature request, that one should be opened in the FreeCAD/FreeCAD tracker.

I don't see anything else to do with this issue here. Closing.