search

Ondsel-Development / FreeCAD

This is the official source code of FreeCAD, a free and opensource multiplatform 3D parametric modeler.
https://www.freecad.org
Other
192 stars 8 forks source link

Recent Files in the Start page do not open if there is an apostrophe in the file path. #117

Open notPelf opened 4 months ago

notPelf commented 4 months ago

Is there an existing issue for this?

Problem description

On the start page, when I click to open a recent file, and the path has an apostrophe in it, I get an error about an unterminated string literal. If there is no apostrophe in the filepath then it opens fine.

To reproduce: 1) save a part to a folder of choice (e.g. I made a folder on my desktop called "test") 2) close and reopen Ondsel 3) on the start page, click on the file in the Recent Files list - it should open normally. 4) close the file, rename the folder so that it has an apostrophe in the name (e.g. "test" -> "test's"), and open it. 5) close and reopen Ondsel again 6) try clicking the test file in the Recent Files list - should result in an error about an unterminated string literal

image

Full version info

OS: Windows 10 build 19045
Word size of Ondsel: 64-bit
Version: 2024.2.2.37240 (Git)
Build type: Release
Branch: (HEAD detached at 2024.2.2)
Hash: fbb794cd2e56fba5fd911c8832332b5e5e235319
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: English/United States (en_US)
Installed mods: 
  * Ondsel-Lens 2024.5.6.01

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct

sliptonic commented 4 months ago

@pieterhijma An apostorphe is legal in a folder name. I've assigned this to you since you've been looking at the new start wb code and probably know exactly where the string needs to be sanitized.