Ondsel-Development / FreeCAD

This is the official source code of FreeCAD, a free and opensource multiplatform 3D parametric modeler.
https://www.freecad.org
Other
192 stars 9 forks source link

[1.0 Bughunt] [CAM] Dressup Tag allows user to select objects that are not a valid path and then gives a lot of "red ink" errors. #124

Open spanner888 opened 4 months ago

spanner888 commented 4 months ago

Is there an existing issue for this?

Problem description

If user does not select a path to apply Tag dressup to, but instead for example selects the stock or model, the following red ink errors occur:

`Tags.ERROR: The selected object is not a path

08:03:02 Running the Python command 'CAM_DressupTag' failed: Traceback (most recent call last): File "/home/spanner888/Documents/_source/_APPS/ondsel/squashfs-root/usr/Mod/CAM/Path/Dressup/Gui/Tags.py", line 592, in Activated FreeCADGui.doCommand( File "", line 1, in File "/home/spanner888/Documents/_source/_APPS/ondsel/squashfs-root/usr/Mod/CAM/Path/Dressup/Gui/Tags.py", line 556, in Create obj.ViewObject.Proxy = PathDressupTagViewProvider(obj.ViewObject) ^^^^^^^^^^^^^^

'NoneType' object has no attribute 'ViewObject'`

Suggest Tag dressup should have same behaviour as other dressups that are disabled if incorrect object selected (or not enabled until valid object selected.

Full version info

OS: Debian GNU/Linux 12 (bookworm) (XFCE/xfce)
Word size of Ondsel: 64-bit
Version: 2024.2.1.37226 (Git)
Build type: Release
Branch: (HEAD detached at 2024.2.1)
Hash: 1a1bd7290494aef925a026c87b808ac58d53c3b0
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: English/Australia (en_AU)
Installed mods: 
  * btl 0.9.9 (Disabled)

Also occurs in FC Stable 21.2:
[code]
OS: Debian GNU/Linux 12 (bookworm) (XFCE/xfce)
Word size of FreeCAD: 64-bit
Version: 0.21.2.33771 (Git)
Build type: Release
Branch: (HEAD detached at 0.21.2)
Hash: b9bfa5c5507506e4515816414cd27f4851d00489
Python 3.10.13, Qt 5.15.8, Coin 4.0.0, Vtk 9.2.6, OCC 7.6.3
Locale: English/Australia (en_AU)
Installed mods: 
  * btl 0.9.9 (Disabled)
[/code]

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct