OneArgo / ArgoVocabs

A repository for the management of issues related to vocabularies managed by the Argo Data Management Team
7 stars 0 forks source link

Add an association between PLATFORM_TYPE, PLATFORM_MAKER and WMO_INST_TYPE for FileChecker consistency checks #82

Open delphinedobler opened 8 months ago

delphinedobler commented 8 months ago

In the original argo Reference table 23 (https://docs.google.com/spreadsheets/d/1Aw8B7FFUjG4e9MveD5qqvI7ZbB-z_x32IQnpHZbXVZA/edit#gid=2), there was the indication of the possible manufacturer(s) and WMO_INST_TYPE (column IXIXIX (1770)) for a given platform_type. This information is used in the FileChecker, but is absent of https://vocab.nerc.ac.uk/search_nvs/R23/ table. We should find a way to indicate these possible associations in the NVS.

As an additional action, in the FileChecker, MARTEC should be allowed for PROVOR II (PR_version 5.0, 5.1, 5.2 and 5.5) along with NKE (discussed with Vincent B.). This concerns 17 coriolis floats (old ones), for which the meta file update is not possible at the moment.

delphinedobler commented 8 months ago

Edit from JPR @tcarval :

Reference table 23 of the GDAC checker should be updated as follows :

PROVOR_II | 103 | 839 | MARTEC KANNAD NKE | dual board PROVOR | instead of PROVOR_II | 103 | 839 | NKE | dual board PROVOR |

And similarly for the PROVOR: PROVOR | 101 | 840 841 842 | MARTEC KANNAD NKE | |

vpaba commented 6 months ago

Hi @delphinedobler, thank you for raising this.

With regards to linking information between terms in different NVS collections, the creation of 'mappings' can be of use to address exactly this.

I am happy to go through this with you in case, though the steps are described in the NVS website.

To try this, please go to the Vocab Editor tool (https://vocab.nerc.ac.uk/editor/), and click on 'Mappings - bulk uplaod', just above the list your collections, on the right-hand side.

This will take you to the following instructions:

Submit mappings in a pre-prepared comma separated file with NO HEADER.

For NVS to NVS mappings you will need the following columns (all fields mandatory): | Subject collection ID | Subject Concept ID | Relationship ID | Object Collection ID | Object Concept ID | Action |

Action can only be "I" (for insert) or "D" (for deprecate).

Relationship ID needs to be one of the permissible terms from collection C60 (currently: BRD, NAR, SYN, MIN)

To satisfy your request, we could create R23 - R24 and R23 - R08 mappings.

To do this, we would create a simple text file containing the following, for example:

R23, PROVOR, MIN, R24, NKE, I
R23, PROVOR_II, MIN, R24, MARTEC, I
R23, PROVOR_II, MIN, R24, NKE, I
R23, PROVOR, BRD, R08, 840, I
R23, PROVOR, BRD, R08, 841, I
R23, PROVOR, BRD, R08, 842, I
R23, PROVOR_II, BRD, R08, 839, I

*Note that I've not included a mapping to 'KANNAD', as this would need creating in R24 first.

And upload it to the Vocab Editors - mappings page for review and submission.

Please let me know if this would meet your requirements, and if so, whether you'd be happy to try submitting these mappings?

If you encounter any issues or have any questions, please let me know.

Thanks, Violetta

delphinedobler commented 4 months ago

Hi @vpaba ! Thank you very much for your help and indications. From what you explain, I think mappings are convenient. I will try this and will get back to you if I have trouble. I need to have a look on how it looks like when tables are exported (in prevision of the File Checker update).

tcarval commented 1 month ago

Argo uses C60 mappings; example : https://github.com/nvs-vocabs/ArgoVocabs/issues/118

danibodc commented 1 week ago

Hi @delphinedobler if these mappings have been created the ticket can now be closed, thanks!

delphinedobler commented 1 week ago

Hi @danibodc, thank for raising this. I've made some updates, based on Violetta's guidance but it was some time ago and I don't remember well but I did not fulfill completely. I will double check and complete and provide a status before ADMT. This ticket was twofold: one part on the NVS tables, and one on the file checker configuration file. @tcarval: have you added the mapping between PROVOR/PROVOR II and MARTEC in the configuration files of the file checker, or does this still need to be done ?