Fix #67 - Support filtering arrivals by route for each stop

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo

Other

52 stars 18 forks source link

Fix #67 - Support filtering arrivals by route for each stop #100

Closed barbeau closed 7 years ago

barbeau commented 7 years ago

TODO:

[x] Persist the user's answer as to which routes they want to hear arrivals for, both within the session when setting the filter and finally to DynamoDB
[x] Actually filter out the arrivals when reading predictions to user
[x] Don't save HashMaps or HashSets to sessions (they get converted by Alexa to ArrayLists)
[x] Fix issue with setting for stop with duplicate stop ID (it currently loops back to beginning of onboard (askForCity(Optional.empty()).
[x] Fix issue with filter not being used after setting new stop ID in the immediately returned arrival info ("...Right now,...")
[x] What happens if you ask for arrivals for a stop, and the only arrival for that stop gets filtered out? Seems like it might be an empty string. If so, we need to check for this and then say "there are no arrivals in the next X minutes."
[x] Unit tests

coveralls commented 7 years ago

Coverage decreased (-6.2%) to 52.6% when pulling 399e450bf3f137a6d3c5db5465b2447115698e36 on route-filter into 874bbf5d4b4f96ee60508d57d1bf22a7d8315356 on master.

coveralls commented 7 years ago

Coverage decreased (-7.08%) to 51.719% when pulling 7a6edf57a762c0a8fdc517bbada220c38d55a2d1 on route-filter into 874bbf5d4b4f96ee60508d57d1bf22a7d8315356 on master.

coveralls commented 7 years ago

Coverage decreased (-7.8%) to 55.92% when pulling a3ddd625846093be2972e74947728ccdcb5eb9b7 on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage decreased (-7.8%) to 55.966% when pulling 76eb7031236e8791ac114c8fc2c1b7ab49244c06 on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage decreased (-7.7%) to 56.011% when pulling 5bd7df53443ee1380b5aded59684c74aa468bc4c on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage decreased (-7.7%) to 56.011% when pulling 710088eeb1d4028d644c739f8337ee30d672ff25 on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage decreased (-7.7%) to 56.011% when pulling fe7b3779c1d86529343c5afaa865d3868b24f908 on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage decreased (-4.5%) to 59.264% when pulling 1a452a4b1f1be3f3a55a58aa1e5010873c010cbc on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage decreased (-4.5%) to 59.264% when pulling c1fc1b54a55095ed6ead1dc58806721828069f02 on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage decreased (-4.5%) to 59.264% when pulling c1fc1b54a55095ed6ead1dc58806721828069f02 on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage decreased (-3.8%) to 59.972% when pulling 153423c1b551c4cb6d33d44b1cd73c74199dbcae on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage decreased (-3.8%) to 59.972% when pulling 8d642c31aa6844dbd94ab5ffb476ace24bd92bde on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage increased (+2.3%) to 66.054% when pulling 5f7dd3f72dc013cd04ba790530e885b44ef6c7a2 on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage increased (+2.4%) to 66.195% when pulling b935751ab3d70595c58af44acd9a044268315cc8 on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage increased (+2.4%) to 66.195% when pulling 92f17e3bbbfbabf0c1aaef28338fd21c4796da37 on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.

coveralls commented 7 years ago

Coverage increased (+2.5%) to 66.243% when pulling a0071c4b584b52b297134bd3a5646554ee4086bd on route-filter into 1278d09c08c16f498792311fa526cfb7941f6084 on master.