OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo
Other
52 stars 18 forks source link

Fix #111 - Migration to Alexa Java SDK V2 and implement skill personalization #112

Closed victormocz closed 4 years ago

victormocz commented 4 years ago

This is the change migrated OneBusAway from Alexa JavaSDK V1 to JavaSDK V2 and OneBusAway personalization.

changes have been E2E tested.

Working on the ICLA and will send it through the email later. Thanks.

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

barbeau commented 4 years ago

I can confirm that we have a CLA on file for @victormocz that was signed and sent separately.

barbeau commented 4 years ago

I'm going to close and re-open the PR to see if I can get Travis to pass it with the new config in the master branch.

barbeau commented 4 years ago

@victormocz I fixed Travis CI builds, so that should help find issues now too.

On that note, I noticed the build is currently failing due to onebusaway.properties not existing in the repo:

FAILURE! - in org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest
handleWithoutObaData_cityInSession_askForCityResponse(org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest)  Time elapsed: 0.694 sec  <<< ERROR!
java.lang.ExceptionInInitializerError
    at org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest.setup(LaunchRequestHandlerTest.java:44)
Caused by: org.springframework.beans.factory.BeanDefinitionStoreException: Failed to parse configuration class [org.onebusaway.alexa.config.ApplicationConfig]; nested exception is java.io.FileNotFoundException: class path resource [onebusaway.properties] cannot be opened because it does not exist

We previously had Travis working even when the onebusaway.properties file wasn't in the repo - would you be able to take a look at fixing that?

victormocz commented 4 years ago

@victormocz I fixed Travis CI builds, so that should help find issues now too.

On that note, I noticed the build is currently failing due to onebusaway.properties not existing in the repo:

FAILURE! - in org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest
handleWithoutObaData_cityInSession_askForCityResponse(org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest)  Time elapsed: 0.694 sec  <<< ERROR!
java.lang.ExceptionInInitializerError
  at org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest.setup(LaunchRequestHandlerTest.java:44)
Caused by: org.springframework.beans.factory.BeanDefinitionStoreException: Failed to parse configuration class [org.onebusaway.alexa.config.ApplicationConfig]; nested exception is java.io.FileNotFoundException: class path resource [onebusaway.properties] cannot be opened because it does not exist

We previously had Travis working even when the onebusaway.properties file wasn't in the repo - would you be able to take a look at fixing that?

Done, I refacoring the UTs and it working without properties file