Closed victormocz closed 4 years ago
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
I can confirm that we have a CLA on file for @victormocz that was signed and sent separately.
I'm going to close and re-open the PR to see if I can get Travis to pass it with the new config in the master branch.
@victormocz I fixed Travis CI builds, so that should help find issues now too.
On that note, I noticed the build is currently failing due to onebusaway.properties
not existing in the repo:
FAILURE! - in org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest
handleWithoutObaData_cityInSession_askForCityResponse(org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest) Time elapsed: 0.694 sec <<< ERROR!
java.lang.ExceptionInInitializerError
at org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest.setup(LaunchRequestHandlerTest.java:44)
Caused by: org.springframework.beans.factory.BeanDefinitionStoreException: Failed to parse configuration class [org.onebusaway.alexa.config.ApplicationConfig]; nested exception is java.io.FileNotFoundException: class path resource [onebusaway.properties] cannot be opened because it does not exist
We previously had Travis working even when the onebusaway.properties
file wasn't in the repo - would you be able to take a look at fixing that?
@victormocz I fixed Travis CI builds, so that should help find issues now too.
On that note, I noticed the build is currently failing due to
onebusaway.properties
not existing in the repo:FAILURE! - in org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest handleWithoutObaData_cityInSession_askForCityResponse(org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest) Time elapsed: 0.694 sec <<< ERROR! java.lang.ExceptionInInitializerError at org.onebusaway.alexa.handlers.intent.LaunchRequestHandlerTest.setup(LaunchRequestHandlerTest.java:44) Caused by: org.springframework.beans.factory.BeanDefinitionStoreException: Failed to parse configuration class [org.onebusaway.alexa.config.ApplicationConfig]; nested exception is java.io.FileNotFoundException: class path resource [onebusaway.properties] cannot be opened because it does not exist
We previously had Travis working even when the
onebusaway.properties
file wasn't in the repo - would you be able to take a look at fixing that?
Done, I refacoring the UTs and it working without properties file
This is the change migrated OneBusAway from Alexa JavaSDK V1 to JavaSDK V2 and OneBusAway personalization.
changes have been E2E tested.
Working on the ICLA and will send it through the email later. Thanks.