search

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo
Other
52 stars 18 forks source link

Fix #116 - Add pause before personal prompt, remove dups #117

Closed victormocz closed 4 years ago

victormocz commented 4 years ago

Personalization prompt fix

This change will fix the #116

Changes

  1. Add a comma between in arrival information.
  2. Removed personalized prompt for NO_ARRIVALS and NO_ARRIVALS_AFTER_FILTER for the duplicated names.
CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

chunzhang mo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 21.794% when pulling 437c1db4dafc45b5c5dc2d9781568a9720f34502 on victormocz:prompts into f184a1a62095db77f1dbe2af51490bb0fe2051c4 on OneBusAway:master.

barbeau commented 4 years ago

Thanks @victormocz!

victormocz commented 4 years ago

Thank you @barbeau for your quick response :)