stop_id is repeated to user instead of stop_code

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo

Other

52 stars 18 forks source link

stop_id is repeated to user instead of stop_code #13

Closed barbeau closed 8 years ago

barbeau commented 8 years ago

Originally mentioned in https://github.com/OneBusAway/onebusaway-alexa/pull/8#issuecomment-185003111:

In OBA (and GTFS), stop_id is intended to be an internal agency-facing field. stop_code is the rider-facing ID that's actually shown on the bus sign. For some agencies these are the same, but for others they are different.

We are currently reading back the stop_id to the user - we should instead read back the stop_code via ObaStop.getStopCode().

barbeau commented 8 years ago

We'll probably want to persist stop_code as well, in case we need to read it to the user elsewhere in the lifecycle.

barbeau commented 8 years ago

Fixed via https://github.com/OneBusAway/onebusaway-alexa/pull/19.