search

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo
Other
52 stars 18 forks source link

Add skill help and more utterances #27

Closed philipmw closed 8 years ago

philipmw commented 8 years ago

Addresses issue #3.

barbeau commented 8 years ago

Thanks @philipmw, this is looking good. I think the only item we're missing from #3 is to allow the user to retrieve a list of supported regions. I'd like this to be sorted based on proximity to the set city, and should only read out regions that have a ObaBaseUrl (same criteria we are using to actually set the region, vs. asking for the city again). There is some code in OBA Android we can pull from (in RegionsFragment, IIRC) for the proximity sorting.

Do you want to tackle this in this PR, or do you want me to take a shot separately?

philipmw commented 8 years ago

Gonna post my reply to the issue.

barbeau commented 8 years ago

Per discussion in #3 we are going to handle exposing region info a bit differently than I men tion above. So, this LGTM. Thanks!