OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo
Other
52 stars 18 forks source link

Setting a city is broken #42

Closed barbeau closed 8 years ago

barbeau commented 8 years ago

Setting a city no longer works after going through the initial UX bootstrap.

Steps to reproduce:

  1. Do the initial setup (e.g., Tampa Bay region, stop 3105).
  2. Say "Alexa, ask OneBusAway to set my city to Seattle"

What I hear:

...and my city/region doesn't change.

\ What I expect:**

Alexa should say:

...and my region/stop number should change.

Cause:

I believe this is happening because starting in https://github.com/OneBusAway/onebusaway-alexa/pull/41 we are always writing the persisted user data to the session variables - I believe in the above case, we're overwriting the existing city/region session variable that was set by the user in the same session.

I'm working on a fix.

philipmw commented 8 years ago

Wow, nice find.