Fix #42 - Only save persisted data to session if it doesn't exist

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo

Other

52 stars 18 forks source link

Fix #42 - Only save persisted data to session if it doesn't exist #43

Closed barbeau closed 8 years ago

barbeau commented 8 years ago

~~Please don't merge yet~~

* This successfully fixes the issue, but the tests still aren't passing. Need to fix the tests and squash.

Also update Tampa region name to "Tampa Bay"

barbeau commented 8 years ago

@philipmw I'm not going to have more time to work on this tonight, but if you feel so inclined feel free to try and fix the unit test ;).

barbeau commented 8 years ago

@philipmw Ok, I just force-pushed a new commit to replace the old, and I believe it's ready for review. The tests now pass, although I'm still not sure I know exactly what I'm doing with JMockit. Could you please take a closer look and see if the unit test makes sense?

philipmw commented 8 years ago

Thanks for this. I think we have the same thought: it's not the best solution and we may need to rethink the Anon vs. Authed separation, especially if we add user state that requires more than one back-and-forth between Alexa and the user. But we can cross that bridge later.