Fix #48 - Add more utterances

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo

Other

52 stars 18 forks source link

Fix #48 - Add more utterances #50

Closed barbeau closed 8 years ago

barbeau commented 8 years ago

Add "leave" and "departs" in addition to "arrives"
Add most transit types that are listed in GTFS at https://developers.google.com/transit/gtfs/reference#routestxt.
Add a few other phrases

coveralls commented 8 years ago

Changes Unknown when pulling bed7321124b352d740785a9e77916b46013de1c9 on utterances into \ on master**.

barbeau commented 8 years ago

@philipmw Could you take a look at this tonight and merge if all looks ok? Trying to get this and https://github.com/OneBusAway/onebusaway-alexa/issues/49 fixed in the next few days so Amazon can publish skill to beta.

philipmw commented 8 years ago

Howdy, @barbeau. I propose that we use Alexa's word banks feature. We can create a word bank named, say, "TransitModes", and fill it with [bus, train, metro, subway, ...]. Then we can use the TransitModes variable inside our utterances. This keeps our list of utterances tractable.

barbeau commented 8 years ago

Ah, nice, didn't know about word banks. That's definitely a better solution.

barbeau commented 8 years ago

@philipmw Where the heck is the documentation for Alexa word banks? One of my pet peeves with Alexa is Amazon's documentation - it always seems impossible to find what I'm looking for.

barbeau commented 8 years ago

So I asked Alexa dev team about the concept of word banks and if they were supported, and this was their response:

Not really. There are a lot of 3rd party libs, node modules (like alexa-app) etc. that might do that - I would not recommend that route.

Your best result will be to spend the time to spell everything out for each transit mode – we know that will work, and it will not take near as long as you think it will!

@philipmw Let's just stick with the current utterances then. If you can review/merge this and the other PR we can get the skill into beta this week.

barbeau commented 8 years ago

Please hold on merging this - heard back from Amazon again, there is a way to emulate word banks vis custom slots. I'll update this with the new solution.

philipmw commented 8 years ago

I am glad you heard back on custom slots. Thats what I originally meant, and it works very well in another skill I developed. I just didnt get around to writing that up.

barbeau commented 8 years ago

@philipmw Ok, this should be ready for review/merge again. Added a custom slot for TRANSIT_MODES.

coveralls commented 8 years ago

Changes Unknown when pulling 5f2acd9c85cebf95e172985a94896db1fd293506 on utterances into \ on master**.