Save repeat text when resetting region/stop

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo

Other

52 stars 18 forks source link

Save repeat text when resetting region/stop #58

Closed barbeau closed 8 years ago

barbeau commented 8 years ago

Previously, if the user reset their region or stop, we didn't change the cached response field on this reset. That could result in some strange behavior, such as the cached response still saying "You live in Seattle", even if the user just changed their city to Tampa.
This patch sets the cached response to the text read after setup to ensure that the cached response always correctly represents the values that the user just set

@philipmw Please take a look.

coveralls commented 8 years ago

Coverage increased (+0.2%) to 52.955% when pulling 499b8bb769d253b9dca94ee4cdef51c9f598e5aa on clearRepeat into 5ae1219e5c2592dd25b4ef30692679d55a50d0be on master.

barbeau commented 8 years ago

@philipmw would you be able to review/merge today or early tomorrow? Goal is to get these deployed so skill can enter beta next Mon/Tues.

philipmw commented 8 years ago

Yes, looking now.

philipmw commented 8 years ago

Nice, makes sense.

barbeau commented 8 years ago

👍