Fix #63 - Address certification feedback

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo

Other

52 stars 18 forks source link

Fix #63 - Address certification feedback #64

Closed barbeau closed 8 years ago

barbeau commented 8 years ago

I'll keep pushing commits here to address various items in #63, and check them off the list there as they are completed.

coveralls commented 8 years ago

Coverage remained the same at 52.113% when pulling b7982121a8afaf29a437453864a455a8ba06b111 on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

coveralls commented 8 years ago

Coverage remained the same at 52.113% when pulling ed89ea9d5235c01239001775e3993112f47405c1 on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

coveralls commented 8 years ago

Coverage increased (+0.3%) to 52.448% when pulling ed48c3e8ccea5e98900e7521d267e4c7b8ba59f3 on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

coveralls commented 8 years ago

Coverage increased (+0.3%) to 52.448% when pulling 600d3c3514afa9a25833c2996766d45abd9a7058 on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

coveralls commented 8 years ago

Coverage increased (+0.3%) to 52.448% when pulling 605ee0e3514cf4a457e031e9576314004d7fac50 on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

coveralls commented 8 years ago

Coverage increased (+1.9%) to 53.968% when pulling 9efbab4405dbcf52a90e44b1dc9f786314cf448d on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

barbeau commented 8 years ago

@philipmw Could you please go ahead and start reviewing the commits in this WIP PR?

I'm going to try and tackle the last one related to utterances (mentioned in https://github.com/OneBusAway/onebusaway-alexa/issues/63#issuecomment-213652739) likely tomorrow.

barbeau commented 8 years ago

@philipmw Also, I should mentioned I haven't tested any of these commits with my Echo yet, so additional testing there would also be appreciated.

coveralls commented 8 years ago

Coverage increased (+1.9%) to 53.968% when pulling f46b66ab5800d5b15cbbbebe7925ae59c58806f4 on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

coveralls commented 8 years ago

Coverage increased (+1.9%) to 53.968% when pulling a68b76dddc9a53a1fbbec76acdf6e37765514a82 on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

coveralls commented 8 years ago

Coverage increased (+1.9%) to 53.968% when pulling a4da204771163b498a4b908377d439ca96210c7b on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

coveralls commented 8 years ago

Coverage increased (+1.9%) to 53.968% when pulling c7f388c9271655af3cb7d5f204e23023a6a2eb40 on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

coveralls commented 8 years ago

Coverage increased (+1.6%) to 53.759% when pulling 15063db1d2903bf70ec6d8acbee9a3174aa131f0 on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.

barbeau commented 8 years ago

@philipmw I think we're looking pretty good here. Almost everything seems to be working well.

I'm still having issues with setting "Atlanta" as a city, though. Could you do me a favor and try setting your city to Atlanta?

I've tested this by:

"Ask OneBusAway to set my city"

and then:

"Atlanta"

I'm not sure if it's just how I pronounce it, but based on the history in the Alexa app Alexa is hearing all kinds of variations that don't result in it getting the city name around 70% of the time, including:

how lanta
at lanta
add lanta
set lanta
pet lanta
have lanta
lanta

It would be good to know if it's just me or a larger issue.

barbeau commented 8 years ago

Good news - Amazon said Atlanta recognition issue was on their end, should be fixed in release this weekend.

@philipmw Heads up - I'm going to do a last review and merge of this tonight (my time - so in roughly 3-4 hours) so I can re-submit for certification tonight. If you can't get comments in before then we can fix in future PRs.

philipmw commented 8 years ago

It looks good to me.

coveralls commented 8 years ago

Coverage increased (+1.6%) to 53.759% when pulling 87054cad1994f8cb463df95e2acf1282568fd22a on certFeedback into a80fa88231ae68563ee1327dc60ef33f41baec23 on master.