Fix #68 - Improve welcome onboard message

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo

Other

52 stars 18 forks source link

Fix #68 - Improve welcome onboard message #72

Closed barbeau closed 8 years ago

barbeau commented 8 years ago

I'm going to push commits here as I work on this.

coveralls commented 8 years ago

Coverage increased (+0.09%) to 53.846% when pulling a440a8156274fbe78aef714396b8d0162970af61 on newWelcome into 26f075b98434e92af221f90fbf0e4f0e37b6accb on master.

coveralls commented 8 years ago

Coverage increased (+0.4%) to 54.12% when pulling 05f755ea4904200f30c88d1babff30beb764bb9a on newWelcome into 26f075b98434e92af221f90fbf0e4f0e37b6accb on master.

barbeau commented 8 years ago

@philipmw Alright, I've squashed the commits - this should be ready for review. Please test this on your Echo as well - I had something strange happen last night during test (the get arrivals API kept failing), but I think it was a configuration issue with my dev/prod environments. It seemed to work fine again after the problem. But, please give it a test and make sure it runs as expected.

coveralls commented 8 years ago

Coverage increased (+0.4%) to 54.12% when pulling 3250c2ab19997f7dccb61713ea9640fb6b0f8ede on newWelcome into 26f075b98434e92af221f90fbf0e4f0e37b6accb on master.

barbeau commented 8 years ago

@philipmw I'd like to get v1.0 RC back to Amazon cert in the next day or too - would you be able to test this before then?

barbeau commented 8 years ago

It looks like the error I saw when testing this was due to API key rate limiting in Tampa (I'm working with them to fix it). This was only exposed via this patch because now we're calling stops-for-location and arrivals-and-departures-for-stop APIs back-to-back as part of creating the welcome aboard message. I added better OBA error code logging in https://github.com/OneBusAway/onebusaway-alexa/pull/73 to make it easier to debug future API issues.