Fix #53 - Support multiple found stops

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo

Other

52 stars 18 forks source link

Fix #53 - Support multiple found stops #76

Closed vikram31291 closed 8 years ago

vikram31291 commented 8 years ago

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Sign the electronic OBA ICLA
[ ] Apply the OneBusAway style template to your code.
[x] Run the unit tests with mvn test to make sure you didn't break anything
[x] If you have multiple commits please combine them into one commit by squashing them.

barbeau commented 8 years ago

@vikram31291 Thanks for this! I'll hopefully fully review soon. Just a heads up that you'll need to rebase this against the current master branch - there is currently a conflict between the two from commits that have been added to master branch since you started your branch. Also, please use the commit name format "Fix #X - Support multiple found stops", and this way when we merge your PR it will automatically close the issue.

barbeau commented 8 years ago

@vikram31291 Any idea on when you might be able to wrap up development on this? The skill went live June 28th, and it's only matter of time until users start asking for this. From spot testing, there are a good number of duplicate stop codes in regions.

vikram31291 commented 8 years ago

@barbeau I've been able to clean it up and address some of the state comments. I'll send it out again tomorrow morning. I can plant to get this committed this week.

barbeau commented 8 years ago

@vikram31291 Ok, thanks! FYI, there is also a conflict now with master, so you'd need to rebase as part of this as well.