search

OneBusAway / onebusaway-alexa

An Java-based app to communicate with Amazon Alexa for devices such as the Amazon Echo
Other
52 stars 18 forks source link

Filter out arrivals / departures with negative ETA #91

Open lanami opened 7 years ago

lanami commented 7 years ago

Exclude arrival infos where ETA < 0 from Alexa's announcements (this indicates arrivals and departures which already happened).

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 55.048% when pulling 0dee575c2c33321d0e55964afa2104c33b7af794 on lanami:84-filter-departed-arrivals into 7e5c26547582cd62d7f2f3ae95f702bee0c22829 on OneBusAway:master.

barbeau commented 7 years ago

@lanami Thanks for working on this! I'd like to see this as an option that users can turn on and off. For the OBA mobile apps, some users like knowing when they just missed a bus, while others only want upcoming arrivals. Default should be including negative ETAs. Feel free to propose intent and exact keywords.

barbeau commented 7 years ago

Closing and re-opening this to trigger the new ICLA bot (hopefully).

@lanami You'll need to sign the ICLA again, which the bot should hopefully link to in it's comment.

CLAassistant commented 7 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 55.048% when pulling 0dee575c2c33321d0e55964afa2104c33b7af794 on lanami:84-filter-departed-arrivals into 7e5c26547582cd62d7f2f3ae95f702bee0c22829 on OneBusAway:master.

lanami commented 7 years ago

Will do