Closed jswedler closed 7 years ago
I've run this skill on my Echo to confirm the functionality works.
Please make sure these boxes are checked before submitting your pull request - thanks!
[x] Sign the electronic OBA ICLA
[ ] Apply the OneBusAway style template to your code. --These files already don't adhere to the OBA style template (e.g. 4 space tabs)
[x] Run the unit tests with mvn test to make sure you didn't break anything
mvn test
[x] If you have multiple commits please combine them into one commit by squashing them.
All committers have signed the CLA.
Coverage increased (+2.3%) to 56.874% when pulling 2be103e43bcb05cc4064f8d6461276972e6456db on jswedler:jswedler/stopfirst into aff540fffbb819390bde97f498196b2aa857cd6c on OneBusAway:master.
@jswedler Thanks for working on this! Hopefully I'll be able to review in the next day or two.
@jswedler Thanks, this looks great! I'll go ahead and cut a new release with this.
I've run this skill on my Echo to confirm the functionality works.
Please make sure these boxes are checked before submitting your pull request - thanks!
[x] Sign the electronic OBA ICLA
[ ] Apply the OneBusAway style template to your code. --These files already don't adhere to the OBA style template (e.g. 4 space tabs)
[x] Run the unit tests with
mvn test
to make sure you didn't break anything[x] If you have multiple commits please combine them into one commit by squashing them.