OneBusAway / onebusaway-android

The official Android app for OneBusAway
http://www.onebusaway.org/
Other
472 stars 291 forks source link

Map view loses state when switching between trip itinerary options #619

Open barbeau opened 8 years ago

barbeau commented 8 years ago

Summary:

Interrelated issues with the map view in the Trip Planner when switching between trip options:

  1. When switching between the 3 trip plan option, the map view snaps to the new trip bounds, which makes it difficult to compare the trips, as you lose orientation of where you're looking at. I think a smooth animation moving the camera to the trip bounds would be easier to follow.
  2. When switching between the 3 trip plan options, the camera doesn't zoom to the full bounds of the trip - the origin and destination are often off-screen.

Steps to reproduce:

  1. Plan a trip with more than on itinerary option
  2. Tap the tab to switch between itineraries

Expected behavior:

I expect the map state/view to be easily trackable, to make it easier to compare the trip options on the map. So when I switch from one option to another, the camera should gently zoom to the extents of the new trip option. The origin and destination of each route should also be visible on the map.

Observed behavior:

For each trip option, the map view resets by snapping to the new trip bounds, but clips the origin and destination.

Device and Android version:

Stock LG G4 w/ Android 6.0

Screenshots:

image

barbeau commented 8 years ago

I'm having problems reproducing the origin/destination off-screen now - not sure why.

barbeau commented 8 years ago

I reproduced the cut-off origin/destination again. I went to the trip planner activity, and then let the phone lock, and then re-opened and planned a trip to the below origin/destination:

image