search

OneBusAway / onebusaway-android

The official Android app for OneBusAway
http://www.onebusaway.org/
Other
475 stars 291 forks source link

Show trip-based alerts on trip details screen #938

Open devinbraun opened 5 years ago

devinbraun commented 5 years ago

Summary:

OBA Android doesn't show an indication that a trip-level alert exists

Steps to reproduce:

View the arrivals including a trip with an active alert.

Expected behavior:

Show an indication that an alert is active for the trip

Observed behavior:

Nothing, no alert was indicated.

OBA Web does show an alert image

iPhone indicates an alert once the specific trip is opened, but nothing on the arrivals view for a stop oba_ipad_screenshot

barbeau commented 5 years ago

Thanks @devinbraun! Could you provide a specific stop/route/trip where a trip_id is active? I need to get a snapshot from the OBA APIs of what the response looks like for these stops/trips.

Off the top of my head, I believe you're correct that alerts don't show up in the "Show trip details" view.

Are you sure that the trip-level alert doesn't appear at the top of the arrivals list? I have a separate issue open for flagging route-specific alerts directly on the arrival item in the list (in addition to showing them at the top of the list with stop-specific alerts) - https://github.com/OneBusAway/onebusaway-android/issues/702.

devinbraun commented 5 years ago

Yes, the trip-level alert does show at the top of the screen. But if it applies only to one trip, I am requesting that it is marked somehow on the actual trip. Here's the API output for a trip-level alert. trip-level alert OBA API output.txt

barbeau commented 5 years ago

But if it applies only to one trip, I am requesting that it is marked somehow on the actual trip.

Sounds good! Yes, that's #702.

I'll leave this issue open for showing alerts in the trip details screen.