fruminator
commented
10 years ago Perhaps fail-vs-warn should be a run-time or configurable option? If you need shapes for inference you want the build to fail if shapes are messed up.
On Tuesday, September 23, 2014, Kurt Raschke notifications@github.com wrote:
With the exception of the OBANYC inference engine, shapes are not vital to the operation of OneBusAway--distance-along-block values may be invalid if shapes are absent or malformed, and users may notice erroneous shapes in the OBANYC UI, but core functionality (such as scheduled and real-time arrival times) will continue to work.
Accordingly, and particularly in light of the practical difficulties encountered in getting valid shapes in many GTFS feeds, the bundle builder should not fail when it encounters stop-to-shape matching errors; rather, it should log a warning and continue as if shapes were not provided.
— Reply to this email directly or view it on GitHub https://github.com/OneBusAway/onebusaway-application-modules/issues/100.
With the exception of the OBANYC inference engine, shapes are not vital to the operation of OneBusAway--distance-along-block values may be invalid if shapes are absent or malformed, and users may notice erroneous shapes in the OBANYC UI, but core functionality (such as scheduled and real-time arrival times) will continue to work.
Accordingly, and particularly in light of the practical difficulties encountered in getting valid shapes in many GTFS feeds, the bundle builder should not fail when it encounters stop-to-shape matching errors; rather, it should log a warning and continue as if shapes were not provided.