Fix implementation of pathway_mode, is_bidirectional, and pathway_type (deprecated)

kurtraschke commented 3 years ago

Summary:

pathways.txt was observed to serialize the deprecated pathway_type field with a value of 0; in addition the required pathway_mode and is_bidirectional fields were missing from serialized output.

Expected behavior:

pathway_type should not be serialized unless explicitly set, and pathway_mode and is_bidirectional should be present in the serialized output.

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with mvn test to make sure you didn't break anything
[x] Format the title like "Fix # - short description of fix and changes"
[x] Linked all relevant issues

kurtraschke commented 3 years ago

@sheldonabrown (or @mmaranda-cs, @jeffmaki?) any objections to merging this?

sheldonabrown commented 3 years ago

Sorry, I missed this. Let me take a look...

jeffmaki commented 3 years ago

Same, but fine by me

On Thu, Jun 17, 2021 at 12:03 PM sheldonabrown @.***> wrote:

Sorry, I missed this. Let me take a look...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OneBusAway/onebusaway-gtfs-modules/pull/176#issuecomment-863365764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDG65223QXDTVH63DB4QDTTIMDJANCNFSM43KPVKAQ .

-- Jeff Maki http://www.jeffmaki.com @jeffmaki 248.225.4954

OneBusAway / onebusaway-gtfs-modules

Fix implementation of pathway_mode, is_bidirectional, and pathway_type (deprecated) #176