search

OneBusAway / onebusaway-gtfs-modules

A Java-based library for reading, writing, and transforming public transit data in the GTFS format, including database support.
Other
129 stars 106 forks source link

AgencyId in SubsectionTripTransformStrategy is not preserved? #181

Open marecabo opened 3 years ago

marecabo commented 3 years ago

Summary:

I suspect that this line

https://github.com/OneBusAway/onebusaway-gtfs-modules/blob/fd87efe1ae2cbd361e6830ce714a5c1393fe97e6/onebusaway-gtfs-transformer/src/main/java/org/onebusaway/gtfs_transformer/updates/SubsectionTripTransformStrategy.java#L106

should actually be like this line

https://github.com/OneBusAway/onebusaway-gtfs-modules/blob/fd87efe1ae2cbd361e6830ce714a5c1393fe97e6/onebusaway-gtfs-transformer/src/main/java/org/onebusaway/gtfs_transformer/updates/TrimTripTransformStrategy.java#L93

because both methods are trimming trips somehow (still need to grasp their differences, though).

Steps to reproduce:

I have not run anything yet, I'm reading and trying to understand the code's functionality.

Expected behavior:

I expect the original AgencyId to persist when transforming a trip, or, if this is not reasonable, to use a configurable AgencyId.

Observed behavior:

The line in SubsectionTripTransformStrategy introduces a new constant AgencyId "1" and does not reuse the AgencyId of the original trip.

Platform:

Thank you for your work at these helpful modules.