search

OneBusAway / onebusaway-gtfs-modules

A Java-based library for reading, writing, and transforming public transit data in the GTFS format, including database support.
Other
129 stars 106 forks source link

StopTime #87

Open pjpsoares opened 7 years ago

pjpsoares commented 7 years ago

I would assume this is not only for StopTime but for every other place that represents date in the same way, but the javadoc is wrong for this. It's not actually the added time after midnight, but the added time after noon minus 12 hours as specified in GTFS. This could cause some strange behavior regarding timetables when the daylight savings time changes occur.

sheldonabrown commented 7 years ago

I'm not sure I follow. The intent of advancing to noon and then back 12 hours is in fact to have consistent handling of timetables during daylight savings changes.

Are you simply suggesting the javadoc is corrected? If so, how about a pull request?

pjpsoares commented 7 years ago

Yes, suggesting that the javadoc is corrected. Will do the PR.

sheldonabrown commented 7 years ago

Great! Thanks.

derhuerst commented 3 years ago

I'm curious, is there any place in onebusaway-gtfs where the GTFS Time semantics are not obeyed, such as conversion from relative arrival/departure times to absolute ones, e.g. when querying departures at a point in time?