Agency Alerts: OBAListView DiffableDataSource can't find item index of headers

[ualch9]

Additionally, DiffableDataSource is flooding stdout with item index errors of header items (but not crashing):

2021-06-24 09:58:09.850758-0700 App[13091:4345657] [DiffableDataSource] Failed to find index of item OBAKit.AnyOBAListViewItem(_anyEquatable: OBAKit.(unknown context at $1080a4320).AnyEquatable(value: OBAKit.OBAListViewHeader(id: "agency_alerts_Washington State Ferries", title: Optional("Washington State Ferries"), isCollapsible: true), isEqual: (Function)), _id: (Function), _configuration: (Function), _separatorConfiguration: (Function), _onSelectAction: (Function), _onDeleteAction: (Function), _leadingContextualActions: (Function), _trailingContextualActions: (Function), _type: AnyHashable(OBAKit.OBAListViewHeader(id: "agency_alerts_Washington State Ferries", title: Optional("Washington State Ferries"), isCollapsible: true)))

Originally posted by @ualch9 in https://github.com/OneBusAway/OBAKit/issues/389#issuecomment-867803156

[aaronbrethorst]

I'm moving this to 'post launch'. I don't think we need to gate release on fixing this.

[aaronbrethorst]

This is breaking the bookmarks tab for users who have a lot of bookmarks.

[ualch9]

@aaronbrethorst any screenshots?

[aaronbrethorst]

@ualch9 emailed you

[ualch9]

thanks, i see it. i’ll get on it.

— alan

---

From: Aaron Brethorst @.> Sent: Friday, August 20, 2021 12:31:50 PM To: OneBusAway/onebusaway-ios @.> Cc: Alan Chu @.>; Mention @.> Subject: Re: [OneBusAway/onebusaway-ios] Agency Alerts: OBAListView DiffableDataSource can't find item index of headers (#421)

@ualch9https://github.com/ualch9 emailed you

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/OneBusAway/onebusaway-ios/issues/421#issuecomment-902910950, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJCX2TUU65ACA4W5QVP7MDT52USNANCNFSM5AJQPOQA.

[ualch9]

@aaronbrethorst is this causing a crash? or is it just messing up the view?

[aaronbrethorst]

@ualch9 it’s causing the app to lock up when it’s opened to the bookmarks tab

[aaronbrethorst]

Any luck so far, @ualch9?

[ualch9]

sorry, been busy. i took a look and reproduced the problem, but i can’t think of whats wrong off the bat.

could be something wrong with too many bookmarks causing the the list to frequently update.

i’ll have time sometime next week if this can wait, otherwise feel free to take a look.

— alan

---

From: Aaron Brethorst @.> Sent: Saturday, August 21, 2021 4:00:34 PM To: OneBusAway/onebusaway-ios @.> Cc: Alan Chu @.>; Mention @.> Subject: Re: [OneBusAway/onebusaway-ios] Agency Alerts: OBAListView DiffableDataSource can't find item index of headers (#421)

Any luck so far, @ualch9https://github.com/ualch9?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/OneBusAway/onebusaway-ios/issues/421#issuecomment-903186138, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJCX2SCLLYO3ZAYJ2VPPLLT6AVZFANCNFSM5AJQPOQA.

[ualch9]

Should clarify, i don’t think the stdout message is related to the view freezing. What the user is encountering might be a separate issue with the load logic.

[aaronbrethorst]

@ualch9 yep you're right.